[Lease.Azure] Async task and options code cleanup #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Jan 30, 2023
Arkatufus
commented
Jan 30, 2023
Arkatufus
commented
Jan 30, 2023
| builder.AddHocon(sb.ToString(), HoconAddMode.Prepend); | ||
|
|
||
| if(AzureCredential is null && ServiceEndpoint is null) | ||
| return; |
There was a problem hiding this comment.
Code cleanup, shortcut Apply to not inject a Setup class if there is no need for it
Arkatufus
commented
Jan 30, 2023
| var setup = new AzureLeaseSetup | ||
| { | ||
| AzureCredential = AzureCredential, | ||
| ServiceEndpoint = ServiceEndpoint, | ||
| BlobClientOptions = BlobClientOptions, | ||
| ApiServiceRequestTimeout = ApiServiceRequestTimeout, | ||
| ConnectionString = ConnectionString, | ||
| ContainerName = ContainerName |
There was a problem hiding this comment.
Code cleanup, remove non-needed information from Setup class
Arkatufus
commented
Jan 30, 2023
| @@ -167,6 +167,7 @@ public async Task<LeaseResource> ReadOrCreateLeaseResource(string name) | |||
| { | |||
| switch ((HttpStatusCode)e.Status) | |||
| { | |||
| case HttpStatusCode.PreconditionFailed: | |||
There was a problem hiding this comment.
Bug fix, we did not use any pre-condition in our code but the driver implicitly added a pre-condition internally, need to capture this exception.
Aaronontheweb
approved these changes
Jan 30, 2023
| @@ -167,6 +167,7 @@ public async Task<LeaseResource> ReadOrCreateLeaseResource(string name) | |||
| { | |||
| switch ((HttpStatusCode)e.Status) | |||
| { | |||
| case HttpStatusCode.PreconditionFailed: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #1251
Still unsure that this is the actual cause of the failure, problem was not reproduced.