Fix Lease release/acquire operation logic #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Lease release op when lease not acquired is a no-op * Lease acquire when lease was not acquired returns idempotent operation task instead of timing out
Arkatufus
commented
Feb 6, 2023
| return true; | ||
| case LeaseActor.InvalidReleaseRequest: | ||
| _log.Info("Tried to release a lease that is not acquired"); | ||
| return true; |
There was a problem hiding this comment.
Logically, since we didn't have the lease, we should return true.
This will cause the plugins to report that the lease have been successfully released, which can be confusing.
This is why the log should be emitted in info level so that we can track that the lease was "successfully released" because we didn't have it in the first place.
Arkatufus
commented
Feb 6, 2023
| @@ -109,25 +120,59 @@ public override async Task<bool> Release() | |||
| public override Task<bool> Acquire() | |||
| => Acquire(null); | |||
|
|
|||
| public override async Task<bool> Acquire(Action<Exception?>? leaseLostCallback) | |||
| public override Task<bool> Acquire(Action<Exception?>? leaseLostCallback) | |||
There was a problem hiding this comment.
To make this idempotent, we could not use async...await pattern
Aaronontheweb
approved these changes
Feb 6, 2023
| { | ||
| if(_log.IsDebugEnabled) | ||
| _log.Debug("Lease is already being acquired"); | ||
| return _acquireTask; |
| case LeaseActor.LeaseReleased: | ||
| return true; | ||
| case LeaseActor.InvalidReleaseRequest: | ||
| _log.Info("Tried to release a lease that is not acquired"); |
There was a problem hiding this comment.
it needs to be INFO because if its not, we could not debug if a lease was "released" because it was actually released or because we didn't have it in the first place
| throw new LeaseTimeoutException( | ||
| $"Timed out trying to acquire lease [{_leaseName}, {_settings.OwnerName}]. It may still be taken."); | ||
| _acquireTask = _leaseActor.Ask(new LeaseActor.Acquire(leaseLostCallback), _timeout) | ||
| .ContinueWith(t => |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posible Fix for #1251
Changes