Migrated AMQP.RabbitMQ Tests to TestContainers #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's 4 legitimate failing unit tests here - will need to look at that. |
4 tasks
condensed down into a single package - no more SignalR.AspNetCore package anymore either.
|
Ok, have tests running on all platforms again - that's an improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The Docker.NET code in this project was extremely byte-rotted, so migrated everything to use TestContainers.RabbitMQ.
Worth noting: it looks like none of these tests have been run properly on the build server for some time. Still looking into that, but in the meantime I'm executing these locally.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):