resolve NRE with AmpqConnection #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Mar 23, 2024
| .Select(pair => new AmqpTcpEndpoint(pair.host, pair.port, details.Ssl)).ToList()); | ||
| .Select(pair => | ||
| details.Ssl == null | ||
| ? new AmqpTcpEndpoint(pair.host, pair.port) |
There was a problem hiding this comment.
Used a ternary operator to determine if we have SSL settings or not - use the appropriate CTOR depending.
|
I would like to have some real test coverage here - working on that via #1890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
close #1659 - a simple
nullcheck is all that was required here.Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):