BenchmarkDotNet migration #57
Conversation
|
@heynickc no need to do this yet since we have a million things going on with Akka 1.3 that prioritize this, but let's figure out why the CI system is behaving poorly :p |
Horusiath
force-pushed
the
benchmark-dot-net-migration
branch
from
758a282
to
b6a9d8e
Compare
| info.Arguments <- args) (System.TimeSpan.FromMinutes 15.0) (* Reasonably long-running task. *) | ||
| if result <> 0 then failwithf "NBench.Runner failed. %s %s" nbenchTestPath args | ||
| Target "Benchmarks" (fun _ -> | ||
| () //TODO: complete BenchmarkDotNet setup |
There was a problem hiding this comment.
I will need some help here - in general BenchmarkDotNet is run as console application. Right now I'm using default output paths for benchmark results, but they could be possibly passed as cmd args.
Hyperion.Tests/Hyperion.Tests.csproj
Outdated
|
|
||
| <ItemGroup> | ||
| <Reference Include="FSharp.Quotations.Evaluator"> | ||
| <HintPath>..\packages\FSharp.Quotations.Evaluator.1.0.7\lib\net40\FSharp.Quotations.Evaluator.dll</HintPath> |
There was a problem hiding this comment.
You should not add a nuget package into the new msbuild15 project in this way
build.fsx
Outdated
| @@ -54,7 +54,7 @@ Target "Build" (fun _ -> | |||
| let additionalArgs = if versionSuffix.Length > 0 then [sprintf "/p:VersionSuffix=%s" versionSuffix] else [] | |||
|
|
|||
| if (isWindows) then | |||
| let projects = !! "./**/*.csproj" | |||
| let projects = !! "./**/*.csproj"// ++ "./**/*.fsproj" | |||
There was a problem hiding this comment.
F# projects are still in this repo, but they are removed from solution and conditionally removed from tests. For some reason I was unable to make dotnet cli work for them.
There was a problem hiding this comment.
Just use the VS 2017 15.3 + netcoresdk 2.0. FSharp should work
Horusiath
force-pushed
the
benchmark-dot-net-migration
branch
from
d89eda8
to
29e37e5
Compare
Horusiath
force-pushed
the
benchmark-dot-net-migration
branch
from
29e37e5
to
cb98966
Compare
Horusiath
force-pushed
the
benchmark-dot-net-migration
branch
from
c93f71f
to
1ffbf88
Compare
|
Implemented via #86 |
This PR replaces existing performance tests projects (all 3 of them) with a single one, using BenchmarkDotNet. I haven't figured out yet, how to write FAKE target for it, but it exports Github-compatible markdown files. I've heard that there's a possibility to setup exports for TeamCity too, but haven't found it yet.