Fixed serialization of exceptions without the default constructor (#64).

[yallie]

Using FormatterServices.GetUninitializedObject instead of Activator.CreateInstance for exception types that don't have a parameterless constructor.

Reflection-based invocation of GetUninitializedObject can be removed once the API is exposed in dotnet core API. See this thread for more info: https://github.com/dotnet/corefx/issues/8133

[Horusiath]

A minor optimization change to be made, beside that it looks good 👍

[Horusiath]

You don't need this check here - it's not like having default constructor or not will change depending on the binary payload ;) You can move this check outside the deserializer function i.e:

Func<Object> initialize = hasDefaultConstructor 
    ? (() => Activator.CreateInstance(type)) 
    : (FormatterServicesGetUninitializedObject(type));

or (without measures I'm not sure which one is faster):

Func<Type, Object> initialize = hasDefaultConstructor 
    ? Activator.CreateInstance 
    : FormatterServicesGetUninitializedObject;

and use initialize inside deserializer.

[Rattenkrieg]

But now it introduces unnecessary delegate allocation.

[Horusiath]

It happens once per exception type, while constructor check will happen once per each object deserialization call. In practice to be 100% sure, we'd need to check both approaches in performance test - I'll be happy to do that once #57 will finally get merged.

[yallie]

You're right, thanks for the suggestion.

[Aaronontheweb]

@Horusiath does this look ok to you now?