Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Finite State Machine DSL to Akka.Persistence #1096

Closed
Horusiath opened this issue Jun 25, 2015 · 5 comments
Closed

Port Finite State Machine DSL to Akka.Persistence #1096

Horusiath opened this issue Jun 25, 2015 · 5 comments
Assignees
@maxim-s
Labels
akka-persistence enhancement

Comments

@Horusiath
Copy link
Contributor

Port FSM to Akka.Persistence. Nice thing to consider is support for recovering mechanism to update not only actor's state, but also it's behavior at the end of recovery cycle.
@Horusiath Horusiath assigned Horusiath and unassigned Horusiath Jun 25, 2015
@maxim-s
Copy link
Contributor

maxim-s commented Oct 12, 2015

I can do it

@maxim-s
Copy link
Contributor

maxim-s commented Oct 15, 2015

I've checked FSM Akka.Persistence and FSM for Akka.Actor also we already have FSM for Akka.Actor and looks like scala implementation has at least 80% the same code. Will we do it by the same way, or try to extract common things and reuse? @Horusiath what do you think about it?

@Horusiath
Copy link
Contributor Author

@maxim-s if it's possible to not duplicate code, that would be great. Since C# doesn't offer traits like scala does, the implementation should probably rely on composition.

Horusiath added a commit that referenced this issue Nov 3, 2015
@Horusiath
Merge pull request #1394 from maxim-s/akka-persistence-fsm-dsl
dce684d 
#1096 Port Finite State Machine DSL to Akka.Persistence
@rogeralsing
Copy link
Contributor

Has this one been merged?

@Horusiath
Copy link
Contributor Author

Yes, PR #1394. This can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxim-s maxim-s

Labels
akka-persistence enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rogeralsing @Horusiath @maxim-s