Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional PipeTo completion handlers #1383

Merged
merged 1 commit into from
Oct 28, 2015
Merged

Conversation

emilingerslev
Copy link
Contributor

Added an optional success and failure handler to PipeTo, to simplify
use of Tasks. PipeTo falls back to original behavior when not supplied.

Added test for both default handlers and the new handlers.

Added an optional success and failure handler to PipeTo, to simplify
use of Tasks. PipeTo falls back to original behavior when not supplied.
@emilingerslev
Copy link
Contributor Author

Resubmit with tests of PR #1381

@emilingerslev
Copy link
Contributor Author

Test seems to fail due to unrelated MultiNodeTestRunner test

@emilingerslev
Copy link
Contributor Author

The tests still seems to fail due to some recurring failure.

Horusiath added a commit that referenced this pull request Oct 28, 2015
Add optional PipeTo completion handlers
@Horusiath Horusiath merged commit bab54d1 into akkadotnet:dev Oct 28, 2015
@scottt732
Copy link

Quick question/possible bug. In this commit, the PipeTo overload shows TaskContinuationOptions.ExecuteSynchronously | TaskContinuationOptions.AttachedToParent. Elsewhere in the docs (https://github.com/petabridge/akkadotnet-code-samples/tree/master/PipeTo), the & operator is used. I'm not sure if this would be an issue w/the docs or with the code.

@Aaronontheweb
Copy link
Member

@scottt732 see #1347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants