Akka.IO bind failed must notify bindCommander of failure #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 👍 |
marcpiechura
added
reviewed positively
reviewed with remarks
and removed
needs review
reviewed positively
labels
marcpiechura
pushed a commit
that referenced
this pull request
Mar 1, 2016
Akka.IO bind failed must notify bindCommander of failure
This was referenced Apr 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to align with scala's AkkaIO:
https://github.com/akka/akka/blob/ddcfb5e4d07b07ab5221175264795235cbcd2492/akka-actor/src/main/scala/akka/io/TcpListener.scala
Origin of the problem:
When running in IIS, the app pool recycle event will likely cause another Bind command that might result in:
"Only one usage of each socket address (protocol/network address/port) is normally permitted".
In that instance, as the Bind command runs in the ctor, the actor crashes without any notification to commander of the failure, so no easy way to detect the error.