Fixed the ScatterGatherFirstCompleted router logic #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,14 +79,18 @@ public ScatterGatherFirstCompletedRoutees(Routee[] routees, TimeSpan within) | |||
| /// <param name="sender">The actor sending the message.</param> | |||
| public override void Send(object message, IActorRef sender) | |||
| { | |||
There was a problem hiding this comment.
I'm a bit iffy on the error handling here. What happens if one of these tasks throws?
There was a problem hiding this comment.
Fixed this by using task completion sources and Status.Failure messages
|
@annymsMthd looks like there are public API changes in here - you'll need to follow this: http://getakka.net/docs/akka-developers/public-api-changes |
|
I have a few upgrades im doing for this |
| var res = routedActor.Ask<int>(new Broadcast(0), TimeSpan.FromSeconds(10)); | ||
| res.Wait(); | ||
| res.Result.ShouldBe(14); | ||
| public DelayStopActor(int id, TimeSpan waitTime) |
There was a problem hiding this comment.
Prob don't need this. I saw that the other actor delays based on id so i can just use that functionality
Horusiath
added a commit
that referenced
this pull request
Mar 11, 2016
…router-logic Fixed the ScatterGatherFirstCompleted router logic
This was referenced Apr 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1718 The spec was using broadcast which never goes through the specific router routee logic