Streams update 2.4.16 #2710
Merged
Streams update 2.4.16 #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| var mat = Sys.Materializer(ActorMaterializerSettings.Create(Sys).WithAutoFusing(false)); | ||
| var t = Source.Single(1) | ||
| .ViaMaterialized(Flow.Identity<int>(), Keep.Both) |
There was a problem hiding this comment.
Should we change Keep.Both to ValueTuple in the future?
There was a problem hiding this comment.
Good idea, I'll change it right away via nuget package.
| /// TBD | ||
| /// Materializer SPI (Service Provider Interface) | ||
| /// | ||
| /// Binary compatibility is NOT guaranteed on materializer internals. |
There was a problem hiding this comment.
We do not provide binary compatibility at the moment. It is redundant sentence
|
Have you implemented this one? |
|
We've reported this bug on the jvm and it was already implemented correctly so no need to port it. |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once #2683 is merged those two changes need to ported too- https://github.com/akka/akka/pull/21989/files#diff-7104b3bccdee7b3ce9073c6f2179f42f- https://github.com/akka/akka/pull/21989/files#diff-3a67e6d52956dd56d88c954b5d90d201andasOutput stream close raceprobably needs to be fixed, couldn't run the test while implemented it