InputStream from StreamConverters.asInputStream respects read() contract #21954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the repo owners verify this patch? |
|
OK TO TEST |
akka-ci
added
validating
|
Test PASSed. |
drewhk
reviewed
Dec 7, 2016
| @@ -117,7 +117,7 @@ private[akka] class InputStreamAdapter( | |||
| @scala.throws(classOf[IOException]) | |||
| override def read(): Int = { | |||
| val a = Array[Byte](1) | |||
| if (read(a, 0, 1) != -1) a(0) | |||
| if (read(a, 0, 1) != -1) a(0) & 0xff | |||
There was a problem hiding this comment.
eh, sign extension. The wonders of not having unsigned types. Great catch btw.
drewhk
approved these changes
Dec 7, 2016
|
Backporting |
ktoso
pushed a commit
to ktoso/akka
that referenced
this pull request
Dec 8, 2016
ktoso
added a commit
that referenced
this pull request
Dec 8, 2016
21 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #21943