Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow AtLeastOnceDelivery parameters to be set from deriving classes (as intended) #3810
Currently all AtLeastOnceDelivery parameters are read from settings passed via
This PR makes the owning actors' properties non-virtual and write through, effectively encapsulating the ones of the semantic. The semantic is additionally updated to handle changing values even as the actor runs (so they can be modified even outside the actor's
The values from settings are still the default.
I also fixed the redelivery interval being fired at double the intended rate.
This might be a potentially breaking change, as the properties are no longer virtual. But anyone overwriting these was not getting what they wanted anyway - so perhaps a good thing they will get a compiler error and thus a chance to update their code to set the interval and other properties properly?
@ondrejpialek need to approve the public API changes: https://getakka.net/community/public-api-changes.html
ondrejpialek left a comment •
I have updated my PR and removed the setters from the properties. I added a convenience constructor overload for the actors to simplify tweaking the settings from a parent constructor call. Let me know what you think (see comments in the relevant code).