Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detailed error message on sending Tcp.Close to TcpManager #4068

Merged
merged 4 commits into from
Nov 26, 2019
Merged

Detailed error message on sending Tcp.Close to TcpManager #4068

merged 4 commits into from
Nov 26, 2019

Conversation

IgorFedchenko
Copy link
Contributor

Close #3768

@Aaronontheweb
Copy link
Member

@IgorFedchenko looks like a merge conflict here

@IgorFedchenko
Copy link
Contributor Author

@Aaronontheweb Indeed, resolved now.

@Aaronontheweb
Copy link
Member

Looks like a compilation failure now

@IgorFedchenko
Copy link
Contributor Author

Sorry for that

Aaronontheweb
Aaronontheweb approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit be08805 into akkadotnet:dev Nov 26, 2019
@IgorFedchenko IgorFedchenko deleted the invalid-command-error-message-fix branch November 27, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System.ArgumentException when trying to close TCP connection
2 participants
@IgorFedchenko @Aaronontheweb