fix race conditions with node exits in MNTR #4204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Feb 11, 2020
| { | ||
| _client.Tell(new ToServer<FailBarrier>(new FailBarrier(name))); | ||
| throw new TimeoutException("Client timed out while waiting for barrier " + name); | ||
| throw new TimeoutException("Client timed out while waiting for barrier " + name, ex); |
There was a problem hiding this comment.
Used to generate clearer error messages when things like barrier timeouts occur
Aaronontheweb
commented
Feb 11, 2020
| @@ -363,6 +363,9 @@ public static Config BaseConfig | |||
| @"akka { | |||
| loglevel = ""WARNING"" | |||
| stdout-loglevel = ""WARNING"" | |||
| coordinated-shutdown.terminate-actor-system = off | |||
There was a problem hiding this comment.
Needed to disable CoordinatedShutdown from running here, so nodes can still pass barriers in the even that they leave the cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a configuration issue that may be responsible for a number of "racy" tests we have in the multi node test runner (MNTR) suite.
Specifically, this fix disables coordinated shutdown so the
ActorSystemdoes not terminate by default when a node leaves the cluster - that way thePlayerFSMon the node that has left can still successfulyl callEnterBarrier(string name)and not blow up the entire test suite.