-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4353 Config.WithFallback is acting inconsistently #4358
Changes from 1 commit
b7cc0d7
52d166e
c9ac33c
0d2bf60
3223e6b
4d5d60a
4695e87
e3b1800
8ce4683
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -196,6 +196,8 @@ public void Merge(HoconObject other) | |
//if both values are objects, merge them | ||
if (thisItem.IsObject() && otherItem.Value.IsObject()) | ||
thisItem.GetObject().Merge(otherItem.Value.GetObject()); | ||
else | ||
modified.Add(new KeyValuePair<string, HoconValue>(otherItem.Key, otherItem.Value)); | ||
} | ||
else | ||
{ | ||
|
@@ -228,6 +230,8 @@ internal HoconObject MergeImmutable(HoconObject other) | |
mergedValue.AppendValue(mergedObject); | ||
thisItems[otherItem.Key] = mergedValue; | ||
} | ||
else | ||
thisItems[otherItem.Key] = otherItem.Value; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So for non- There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah, it causes a lot of missing object fields, I'm surprised that this bug went through the test suite There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a simple test case we can add for this to the HOCON test suite? Thinking about it mostly as a regression test. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We do have rigorous testing suite in the standalone HOCON project, I think we used to have a limited HOCON test suite in Akka, they might be accidentally removed. |
||
} | ||
else | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so if I'm reading this right, if both items are objects, they are to be merged, but how is the alternative supposed to work? what is otherItem's type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HOCON have 3 basic datatypes,
Object
,Array
, andLiteral
.Array
andLiteral
will always override merged object fields, but when anObject
met anotherObject
, they got merged instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The full specification for HOCON can be read here: https://github.com/akkadotnet/hocon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok, I see it now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's give it a shot then