fixed IDisposable calls on EMWASpec and MetricsCollectorSpec
#883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akkadotnet#867 inadvertently included a commit that introduced some recursive disposal calls in these two specs.
|
D'oh sorry about that :( |
|
@sean-gilliam it's cool man - my fault for not noticing it when we were reviewing your PR. We're so used to XUnit being unreliable that we might occasionally miss stuff like this. Doesn't help that TeamCity and the console runner don't make it easy to find the |
Horusiath
added a commit
that referenced
this pull request
Apr 21, 2015
fixed `IDisposable` calls on EMWASpec and MetricsCollectorSpec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#867 inadvertently included a commit that introduced some recursive disposal calls in these two specs.
This undoes those changes and leaves a comment explaining why they're there.