Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@charles-l's solution: add two numbers #21

Closed
wants to merge 2 commits into from

Conversation

akkartik
Copy link
Owner

@akkartik akkartik commented Apr 26, 2019

To see the failing tests:

$ ./subx translate 0*.subx add2.subx -o a.elf  &&  ./subx run a.elf test

Feel free to push changes to this branch as you like.

When (when!) you need to debug things, go back and reread https://github.com/akkartik/mu/blob/master/subx/Readme.md#a-few-hints-for-debugging. And, of course, feel free to email me.

To run:
  $ subx translate 0*.subx add2.subx -o a.elf  &&  subx run a.elf test
akkartik added a commit that referenced this pull request Apr 26, 2019
I'm switching to a more exposed working dynamic after chatting with Charles
Saternos (#19). From now on I'll start
a new branch for big features. Branches won't always pass all their tests.

Phases have gone weeks in the past before being committed all at once.
Developing in a branch gives others the opportunity to see more current
progress and jump in more easily.

Some 'kata' branches for new contributors to start at:
  * add two numbers: #21
  * write a string to a byte stram: #22
  * print a number in decimal to a byte stream: #20
@akkartik akkartik added the hello ☺ exercises reimplementing existing features; good for newcomers label Apr 26, 2019
Copy link
Owner Author

@akkartik akkartik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you for also fixing my test.

@charles-l
Copy link
Collaborator

charles-l commented Apr 26, 2019

btw -- this is a really good intro to the project (either for contributors or for people new to x86 and its calling conventions). Do you want me to move my code elsewhere so other folks can implement the solution themselves?

@akkartik
Copy link
Owner Author

I was thinking about that as well: https://mastodon.social/@akkartik/101994481345011251

But don't worry about it. This branch has your name on it. I'll spin up a new one -- with your test bugfix.

@akkartik akkartik changed the title exercise: add two numbers @charles-l's solution: add two numbers Apr 26, 2019
@akkartik
Copy link
Owner Author

Spun up another copy: #24

@akkartik akkartik closed this Apr 26, 2019
akkartik added a commit that referenced this pull request Apr 27, 2019
I'm switching to a more exposed working dynamic after chatting with Charles
Saternos (#19). From now on I'll start
a new branch for big features. Branches won't always pass all their tests.

Phases have gone weeks in the past before being committed all at once.
Developing in a branch gives others the opportunity to see more current
progress and jump in more easily.

Some 'kata' branches for new contributors to start at:
  * add two numbers: #21
  * write a string to a byte stram: #22
  * print a number in decimal to a byte stream: #20
akkartik added a commit that referenced this pull request Apr 27, 2019
I'm switching to a more exposed working dynamic after chatting with Charles
Saternos (#19). From now on I'll start
a new branch for big features. Branches won't always pass all their tests.

Phases have gone weeks in the past before being committed all at once.
Developing in a branch gives others the opportunity to see more current
progress and jump in more easily.

Some 'kata' branches for new contributors to start at:
  * add two numbers: #21
  * write a string to a byte stram: #22
  * print a number in decimal to a byte stream: #20
akkartik added a commit that referenced this pull request Apr 27, 2019
I'm switching to a more exposed working dynamic after chatting with Charles
Saternos (#19). From now on I'll start
a new branch for big features. Branches won't always pass all their tests.

Phases have gone weeks in the past before being committed all at once.
Developing in a branch gives others the opportunity to see more current
progress and jump in more easily.

Some 'kata' branches for new contributors to start at:
  * add two numbers: #21
  * write a string to a byte stram: #22
  * print a number in decimal to a byte stream: #20
akkartik added a commit that referenced this pull request Apr 29, 2019
I'm switching to a more exposed working dynamic after chatting with Charles
Saternos (#19). From now on I'll start
a new branch for big features. Branches won't always pass all their tests.

Phases have gone weeks in the past before being committed all at once.
Developing in a branch gives others the opportunity to see more current
progress and jump in more easily.

Some 'kata' branches for new contributors to start at:
  * add two numbers: #21
  * write a string to a byte stram: #22
  * print a number in decimal to a byte stream: #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hello ☺ exercises reimplementing existing features; good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants