Function names seem to be unreadable blocks

[jryans]

When trying this out on macOS with iTerm2 and my usual theme, the function names seem to be the same colour as the block, so I can't read them.

Perhaps it's a terminal configuration issue...?

[jryans]

Ah yeah, it looks okay in Terminal:

So, maybe my theme is confused...

[jryans]

Ah yeah, looks like my default theme use the same colour for both foreground text and ANSI normal white, so perhaps it's something like that.

[akkartik]

@jryans and @khinsen, could you try now and check if the colors look better? (The other issues you reported aren't fixed yet.)

[akkartik]

@s-ol

[jryans]

Well, some improvement for me... Function names are readable now, but the code editor contrast has plummeted (yellow keywords blend in with the background now). Theming is hard... 😅

[akkartik]

Ugh, thanks a lot.

Immediately I have two reactions:

• Perhaps I should assume at least 256 colors. 16 is too constrained, and so people tweak the 16 colors. (As is happening here? They're not so illegible on my terminal..)
• If I'm going to be constrained to 16 colors, perhaps a dark background is best.

Thoughts? My focus is on giving a good experience out of the box to anybody running a default LTS OS from say the past 5 years.

[khinsen]

I get the same colors as @jryans (I just posted similar screenshots on the FoC Slack.) 256 colors looks very reasonable nowadays. But I can't help much more - my understanding of terminal color assignments is close to zero.

[jryans]

Yeah, I would say try going for 256 colours, I would assume it works well enough these days. I am however also not an expert with terminal colours.

[s-ol]

I can "third" 256 colors. I think I started unix-ing around ten 10-12 years ago and I'm pretty sure I never had an incompatible terminal (except maybe the linux vtty before launching a desktop?)