Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember Ident position in file #18

Merged
merged 41 commits into from
May 1, 2022
Merged

Remember Ident position in file #18

merged 41 commits into from
May 1, 2022

Conversation

akm
Copy link
Owner

@akm akm commented May 1, 2022 •
edited
Loading

  • Don't allow pass string to create new Ident instance (except in test with asttest package)
  • Add Location field into Ident
  • Define Node interface and Nodes slice type
  • asttest.ClearLocations clears Location s of Idents in given node
  • Use pointer for mandatory struct field such as Ident

akm added 30 commits April 24, 2022 16:38
@akm
✏️ Add comments for ast nods
6181fa0
@akm
💚 Add tests for interface implementations
2cc3521
@akm
✨ Add GetPath method to Goal interface
92a8b44
@akm
♻️ Use NewIdent instead of cast
1af4216
@akm
✨ Change Ident from string to struct which have string Name
86788cc
@akm
♻️ Rename UnitRef.Name to Ident
37773fa
@akm
♻️ NewIdent returns *Ident instead of Ident
3f2dee2
@akm
♻️ Make IdentList extend []*Ident instead of ext.Strings
92cbf5e
@akm
♻️ Extract Parameter.SetConstExpr
6f83470
@akm
👕 Add blank line
13dfd48
@akm
💚 Define test constructors in asttest
f8bc109
@akm
✨ Don't allow string for NewIdent and NewIdentList
29c6342
@akm
✨ Add Token.RawString
6bca7f6
@akm
💚 Don't use constructor to type check
5837e4a
@akm
💚 Use constructors in asttest instead of ones in ast
620a7a8
@akm
✨ Use RawString instead of Value
64175ad
@akm
✨ Don't pass string to NewIdent
1056759
@akm
🚿 Remove unnecessary calling NewIdent with string
e21e484
@akm
♻️ Extract NewIdentFrom and modify argument type of NewIdent
ebd1d0f
@akm
♻️ Modify field order of runes.Position
189f5ca
@akm
✨ Add Location to Ident
e31c1c3
@akm
💚 Add expected location into var_test.go
ddbab15
@akm
💚 Add tests for Node implementations
dac6816
@akm
💚 Fix test for SetConstructor
059d3c8
@akm
✨ Implements Node interface
375da56
@akm
✨ Add Nodes.Compact
4a99704
@akm
✨ Define ast.WalkDown
86dbbf4
@akm
💚 Define asttest.ClearLocations
ee84f9f
@akm
✨ Comment out Nodes.Compact
f7dc702 
because it doesn't work well.
See comment of it for more details
@akm
💚 Add Location or add calling ClearLocations to pass tests
be23a82
@akm akm force-pushed the features/remember_ident_position branch from 1ae39ae to aa7ad14 Compare May 1, 2022 06:33
@akm akm merged commit 5e03377 into main May 1, 2022
@akm akm deleted the features/remember_ident_position branch May 1, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akm