Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups 2023 11 #6

Closed
wants to merge 12 commits into from
Closed

Conversation

PetrGlad
Copy link

@PetrGlad PetrGlad commented Dec 4, 2023

  • Reformat code
  • Benchmark cleanup
  • Explicit check in ttest ensuring that engine .moment > 1

Copy link
Owner

@akochepasov akochepasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change in general. Just some nits.

statmoments/benchmark/bench_bivar.py Outdated Show resolved Hide resolved
statmoments/benchmark/bench_bivar.py Show resolved Hide resolved
statmoments/benchmark/benchlib.py Outdated Show resolved Hide resolved
statmoments/benchmark/benchlib.py Show resolved Hide resolved
statmoments/_native.pyx Outdated Show resolved Hide resolved
statmoments/_native.pyx Outdated Show resolved Hide resolved
statmoments/_native.pyx Outdated Show resolved Hide resolved
statmoments/_native.pyx Outdated Show resolved Hide resolved
statmoments/_native.pyx Outdated Show resolved Hide resolved
statmoments/benchmark/benchlib.py Show resolved Hide resolved
Copy link
Owner

@akochepasov akochepasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing in the benchmark

statmoments/benchmark/benchlib.py Outdated Show resolved Hide resolved
Copy link
Owner

@akochepasov akochepasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing

statmoments/benchmark/benchlib.py Outdated Show resolved Hide resolved
@PetrGlad
Copy link
Author

Remaining changes are integrated into #9

@PetrGlad PetrGlad closed this Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants