Batched benchmark, write benchmark report file #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Name fixes * Version 1.0.1
Note that the shown stats (timing columns) have changed.
Traces count was incorrect.
Closed
|
Just a sample run benchmark-2023-12-17T16_36_15.867646.csv |
|
CI pipeline fails on MacOS with a test error (https://github.com/PetrGlad/statmoments/actions/runs/7240067785/job/19722632486) that I saw before (on Linux) once but could not reproduce anymore. Attaching the logs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing tests do not show realistic performance estimations since for some implementations update and t-test times are not independent. Second issue is that the tests did not show benefits of the new implementation.
To show advantages of the sum implementation benchmark also does batched updates with very long trace sequences and writes more performance metrics to allow fine-grained inspection.
2pass implementation fails with large sequences with out-of-bounds access have to see if this is a bug or limitation of NumPy, for example.
Note that the branch is forked from #6