Skip to content

Commit

Permalink
Fix for-in/off block context initialization for empty destructuring p…
Browse files Browse the repository at this point in the history
…atterns (jerryscript-project#3614)

This patch fixes jerryscript-project#3611.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
  • Loading branch information
rerobika committed Mar 16, 2020
1 parent 7f67795 commit c305aee
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 1 deletion.
3 changes: 2 additions & 1 deletion jerry-core/parser/js/js-parser-statm.c
Original file line number Diff line number Diff line change
Expand Up @@ -1158,7 +1158,8 @@ parser_parse_for_statement_start (parser_context_t *context_p) /**< context */
|| context_p->token.type == LEXER_KEYW_CONST)
{
token_type = context_p->token.type;
has_context = (context_p->token.type != LEXER_KEYW_VAR);
has_context = context_p->next_scanner_info_p->source_p == context_p->source_p;
JERRY_ASSERT (!has_context || context_p->next_scanner_info_p->type == SCANNER_TYPE_BLOCK);
scanner_get_location (&start_location, context_p);

/* TODO: remove this after the pre-scanner supports strict mode detection. */
Expand Down
40 changes: 40 additions & 0 deletions tests/jerry/es2015/regression-test-issue-3611.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

var tcs = [
"for (const [] of $)",
"for (const [] in $)",
"for (let [] of $)",
"for (let [] in $)",
"for (const {} of $)",
"for (const {} in $)",
"for (let {} of $)",
"for (let {} in $)",
];

for (let e of tcs) {
try {
eval (e);
assert (false);
} catch (e) {
assert (e instanceof SyntaxError);
}

try {
eval (e + " {}");
assert (false);
} catch (e) {
assert (e instanceof ReferenceError);
}
}

0 comments on commit c305aee

Please sign in to comment.