Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duration_unit option to Ecto plugin #140

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

DaniruKun
Copy link
Contributor

@DaniruKun DaniruKun commented Apr 20, 2022

Change description

This change adds a new optional option to the Ecto plugin configuration - duration_unit.
It allows the user to override the time unit of the Ecto metrics, allowing to directly pass it through to :telemetry.

What problem does this solve?

Issue number: #139

Example usage

{Plugins.Ecto, [repos: [Shared.Repo], duration_unit: :second]}

Additional details and screenshots

Checklist

  • I have added unit tests to cover my changes.
  • I have added documentation to cover my changes.
  • My changes have passed unit tests and have been tested E2E in an example project.

@akoutmos
Copy link
Owner

Thanks for the contribution! Would you mind also adding this to the other plugins for consistency?

@coveralls
Copy link

coveralls commented Apr 26, 2022

Coverage Status

Coverage increased (+0.07%) to 79.686% when pulling d76e96d on DaniruKun:master into 9dbab16 on akoutmos:master.

@DaniruKun DaniruKun force-pushed the master branch 2 times, most recently from 6d008c0 to 8a3f8ae Compare May 25, 2022 21:52
@DaniruKun DaniruKun marked this pull request as ready for review May 25, 2022 22:20
@DaniruKun
Copy link
Contributor Author

@akoutmos any update?

Copy link
Owner

@akoutmos akoutmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akoutmos akoutmos merged commit eb70231 into akoutmos:master Oct 8, 2022
@akoutmos
Copy link
Owner

akoutmos commented Oct 8, 2022

Sorry for the delay on this one! Merging it in and cutting a new release soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants