Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft: implement pluggable storage #240

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

hauleth
Copy link
Contributor

@hauleth hauleth commented Jul 4, 2024

Change description

Preliminary work for supporting different storages beyond telemetry_metrics_prometheus_core.

What problem does this solve?

Support implementing alternative storage backends (like Peep) for users that require different performance characteristics.

Checklist

  • I have added unit tests to cover my changes.
  • I have added documentation to cover my changes.
  • My changes have passed unit tests and have been tested E2E in an example project.

@hauleth hauleth force-pushed the ft/setup-puggable-storages branch from db511b0 to 6a81402 Compare July 4, 2024 15:15
@hauleth
Copy link
Contributor Author

hauleth commented Jul 4, 2024

@akoutmos I tried running tests locally, but with Elixir 1.16.3 (compiled with Erlang/OTP 25) it fails due to ssl_verify_fun errors, and when I update dependencies it fails for different set of reasons.

@akoutmos
Copy link
Owner

akoutmos commented Jul 4, 2024

Thanks for the contribution! I'm away from my machine today but can look deeper into the ssl_verify_fun issues tomorrow. For now I kicked off CI to validate the changes.

@coveralls
Copy link

Coverage Status

coverage: 78.835% (+0.1%) from 78.698%
when pulling 6a81402 on hauleth:ft/setup-puggable-storages
into 1f6467c on akoutmos:master.

Preliminary work for supporting different storages beyond
`telemetry_metrics_prometheus_core`.
@hauleth hauleth force-pushed the ft/setup-puggable-storages branch from 6a81402 to e165dd0 Compare July 12, 2024 07:16
@hauleth hauleth mentioned this pull request Jul 12, 2024
3 tasks
@hauleth hauleth closed this Jul 12, 2024
@hauleth hauleth deleted the ft/setup-puggable-storages branch July 12, 2024 20:21
@hauleth hauleth restored the ft/setup-puggable-storages branch July 12, 2024 20:21
@hauleth hauleth reopened this Jul 12, 2024
@akoutmos akoutmos merged commit 6022d47 into akoutmos:master Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants