Add AlternatePatchAction #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
akshatkarani
force-pushed
the
patchaction
branch
from
fbb3963
to
9d150a7
Compare
Yes, it's a list where each element if an alternative diff. |
akshatkarani
force-pushed
the
patchaction
branch
2 times, most recently
from
0dc52a6
to
f8886c1
Compare
akshatkarani
force-pushed
the
nextgen
branch
2 times, most recently
from
c293d22
to
74f753f
Compare
akshatkarani
force-pushed
the
patchaction
branch
5 times, most recently
from
3a7e574
to
84f2979
Compare
akshatkarani
force-pushed
the
patchaction
branch
from
84f2979
to
be14567
Compare
akshatkarani
force-pushed
the
patchaction
branch
2 times, most recently
from
ae834bb
to
1b23c11
Compare
akshatkarani
force-pushed
the
patchaction
branch
2 times, most recently
from
1b8740d
to
7d94ee0
Compare
akshatkarani
force-pushed
the
patchaction
branch
8 times, most recently
from
89c2ef5
to
372df4f
Compare
akshatkarani
force-pushed
the
patchaction
branch
2 times, most recently
from
8004c44
to
45ba67a
Compare
akshatkarani
force-pushed
the
patchaction
branch
2 times, most recently
from
106d17a
to
1557eee
Compare
akshatkarani
force-pushed
the
nextgen
branch
4 times, most recently
from
1f12998
to
b3901ed
Compare
akshatkarani
force-pushed
the
patchaction
branch
2 times, most recently
from
6b2b630
to
d3d08d9
Compare
This adds a new attribute `alternate_diffs` to Result class. It is a list of dictionaries where each element is an alternate patch suggested by the bear. Corresponding to each `alternate_diff` an instance of AlternatePatchAction is added to the list of actions.
akshatkarani
force-pushed
the
patchaction
branch
from
d3d08d9
to
0500f0d
Compare
|
@akshatkarani Appveyor is failing because it can't find the appveyor.yml file in home directory. Manually add the path to the appveyor.yml file in your CI settings. |
|
Also, create a PR on the upstream repo now. |
Done coala#6057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new attribute in
Resultclass,alternate_diffswhich is the list of alternative patches that bear is suggesting. For eachalternate_diffanAlterantePatchActioninstance is added.The idea is very similar to adding multiple instances of
ShowPatchAction,AlternatePatchActionjust helps with manipulating between the original patch and the alternate patch.Also because of the way how the user chooses an action and how actions are printed on the screen,
AlternatePatchActionneeds it's ownget_metadatafunction. The part of updating the description and passingcountseems a little hackish but I didn't see any other way.