Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mongoDBMajorVersion update support #77

Merged

Conversation

supersol
Copy link

should fix issue
#60

@codecov-io
Copy link

codecov-io commented Mar 15, 2019

Codecov Report

Merging #77 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   41.04%   40.94%   -0.11%     
==========================================
  Files          11       11              
  Lines        1206     1209       +3     
==========================================
  Hits          495      495              
- Misses        710      713       +3     
  Partials        1        1
Impacted Files Coverage Δ
mongodbatlas/resource_mongodbatlas_cluster.go 43.11% <0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54dd3b6...0ee3cc7. Read the comment docs.

@supersol supersol force-pushed the support_mongodbMajorVersion_change branch from b975f4d to 0ee3cc7 Compare April 5, 2019 08:48
@akshaykarle akshaykarle merged commit 0c3e9d8 into akshaykarle:master May 2, 2019
@JamesCampbellIDBS
Copy link

@akshaykarle Thanks for approval and merging this fix. Would you be able to do a new release with this fix in, so we can test, and roll out? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants