Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance Sign-In/Sign-Up Form with Professional UI and Zod Valid… #23

Closed
wants to merge 1 commit into from

Conversation

airajena
Copy link

@airajena airajena commented Jun 8, 2024

Description

This PR significantly improves the Sign-In and Sign-Up components by introducing a more professional and aesthetically pleasing UI, along with robust form validation using Zod. Below is a detailed list of the changes made:

Changes Made

UI/UX Improvements:

  • Introduced a modern, responsive design using Tailwind CSS.
  • Added branding elements such as a logo and a gradient background.
  • Enhanced the form layout for better user experience and readability.
  • Included a toggle to switch between Sign-In and Sign-Up forms seamlessly.
  • Added "Sign Up with Google" and "Sign Up with Facebook" buttons to facilitate social sign-ups.

Form Validation:

  • Integrated Zod for schema-based form validation.
  • Created separate schemas for Sign-In (signInSchema) and Sign-Up (signUpSchema) forms.
  • Implemented validation logic to provide real-time feedback on input errors.
  • Ensured password confirmation match validation in the Sign-Up form.

State Management:

  • Utilized React hooks (useState) for managing form state and validation errors.
  • Added functions to handle input changes and form submissions effectively.

Technical Details

File Changes:

  • SignIn.js: Major changes to the component structure, adding validation and new UI elements.
  • validation.js: New file containing Zod schemas for form validation.

Dependencies Added:

  • zod: Schema declaration and validation library.

Screenshots

Screenshot (156)
Screenshot (157)

@cb7chaitanya
Copy link
Collaborator

@0xaira Bro, first of all I didn't assign you the issue, I was waiting for other contributors to comment too, that is why put you guys in a group, also the form is incorrect, it is not matching the existing UI scheme for the website

The zod validation is also in the wrong place, we will put all the zod validators in the packages folder and reuse them for the backend too

The biggest thing is, the Form component expects more fields when signing up that is why i put the hint to take a look at the existing donation form and volunteer form for all the fields, if not that take a look at the prisma schema in the Backend

@airajena
Copy link
Author

airajena commented Jun 8, 2024

@cb7chaitanya,

Thank you for providing these insights. However, I must apologize as I currently don't have the bandwidth to contribute to this issue. I appreciate your understanding. Please feel free to assign it to someone else who has the capacity to address these concerns.

Best regards,
Aira

@cb7chaitanya
Copy link
Collaborator

Alright closing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants