trigger onDisconnect when disconnect method is called #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faogustavo
changed the title
As the management of connection status in on JS, we should keep the default callbacks to ensure this data. Without then, if I remove all listeners and add a new for connect/disconnect, I will not be able to disconnect again :)
aksonov
requested changes
Nov 28, 2017
| NativeAppEventEmitter.addListener(map.loginError, this.onLoginError), | ||
| NativeAppEventEmitter.addListener(map.login, this.onLogin), | ||
| ]; | ||
|
|
There was a problem hiding this comment.
Could you clarify this change? Why this.listener = this.listeners? Why to add listeners within removeListeners method?
There was a problem hiding this comment.
Wow, sorry, that wasn't right. Already fixed it.
The change is to invoke onDisconnected when disconnected by code.
All callbacks must be setted again because all logic (if the lib is connected or not) is on the JS, so we need to listen the events to change the values.
When I did not added that all default listeners, and I got disconnected (eg. logout button), and remove all listeners, I was not able to create a new connection (JS var did not updated). Keeping these prevent this to occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.