-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Credentials management page #1710
Conversation
Signed-off-by: Remington Breeze <remington@breeze.software>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1710 +/- ##
=======================================
Coverage 44.13% 44.13%
=======================================
Files 207 207
Lines 13105 13105
=======================================
Hits 5784 5784
Misses 7078 7078
Partials 243 243 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval based on screenshots
@rbreeze |
@krancour Oh, there is a front end validation check to make sure that they are mutually exclusive. But I can see how the UI is confusing -- I'll work on an improvement to that part |
ui/src/features/project/credentials/delete-credentials-modal.tsx
Outdated
Show resolved
Hide resolved
ui/src/features/project/credentials/create-credentials-modal.tsx
Outdated
Show resolved
Hide resolved
This makes me wonder if we can't do more on the back-end to allow both an "exact" match and regular expression in just the |
After #1270 set that precedent, I can get down with that. I'll work on that now so it gets into v0.5.0... I don't want to break the credential format twice. @rbreeze those two fields can be combined now, I guess, but I think a checkbox for "is regex" would still be a nicer UX than requiring people to somehow know they can optionally prefix the URL with "regex:". |
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
List View:
Create:
Edit:
Delete:
With the addition of tabs, I've slightly redesigned and refactored the freightline view as well (the banner text is now outside of the grey area):