Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Credentials management page #1710

Merged
merged 4 commits into from
Mar 30, 2024
Merged

feat: Credentials management page #1710

merged 4 commits into from
Mar 30, 2024

Conversation

rbreeze
Copy link
Contributor

@rbreeze rbreeze commented Mar 28, 2024

List View:
Screenshot 2024-03-28 at 14 20 11

Create:
Screenshot 2024-03-28 at 14 20 19

Edit:
Screenshot 2024-03-28 at 14 20 27

Delete:
Screenshot 2024-03-28 at 14 20 40

With the addition of tabs, I've slightly redesigned and refactored the freightline view as well (the banner text is now outside of the grey area):

Screenshot 2024-03-28 at 14 20 54 Screenshot 2024-03-28 at 14 21 02

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from a team as a code owner March 28, 2024 21:22
Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 69c31e8
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/66075670f501f20008b6fe45
😎 Deploy Preview https://deploy-preview-1710.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.13%. Comparing base (a24b7d0) to head (69c31e8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1710   +/-   ##
=======================================
  Coverage   44.13%   44.13%           
=======================================
  Files         207      207           
  Lines       13105    13105           
=======================================
  Hits         5784     5784           
  Misses       7078     7078           
  Partials      243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval based on screenshots

@krancour
Copy link
Member

krancour commented Mar 28, 2024

@rbreeze repoURL and repoURLPattern are supposed to be mutually exclusive. Is it at all possible that we could just make this one field with a checkbox for "is regular expression" or something?

@rbreeze
Copy link
Contributor Author

rbreeze commented Mar 28, 2024

@krancour Oh, there is a front end validation check to make sure that they are mutually exclusive. But I can see how the UI is confusing -- I'll work on an improvement to that part

@hiddeco
Copy link
Contributor

hiddeco commented Mar 29, 2024

repoURL and repoURLPattern are supposed to be mutually exclusive. Is it at all possible that we could just make this one field with a checkbox for "is regular expression" or something?

This makes me wonder if we can't do more on the back-end to allow both an "exact" match and regular expression in just the repoURL field. Either by allowing e.g. regexp:<regex> like we have been doing in #1270, or by automagically detecting special regex characters.

@krancour
Copy link
Member

This makes me wonder if we can't do more on the back-end to allow both an "exact" match and regular expression in just the repoURL field. Either by allowing e.g. regexp: like we have been doing in #1270, or by automagically detecting special regex characters.

After #1270 set that precedent, I can get down with that. I'll work on that now so it gets into v0.5.0... I don't want to break the credential format twice.

@rbreeze those two fields can be combined now, I guess, but I think a checkbox for "is regex" would still be a nicer UX than requiring people to somehow know they can optionally prefix the URL with "regex:".

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze
Copy link
Contributor Author

rbreeze commented Mar 30, 2024

Updated UI to reflect discussed changes:

Screenshot 2024-03-29 at 17 00 21 Screenshot 2024-03-29 at 17 00 29 Screenshot 2024-03-29 at 17 00 34

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze enabled auto-merge March 30, 2024 00:02
@rbreeze rbreeze added this pull request to the merge queue Mar 30, 2024
Merged via the queue into main with commit 1975406 Mar 30, 2024
16 checks passed
@rbreeze rbreeze deleted the credentials-ui branch March 30, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants