Skip to content

Commit

Permalink
fix(package-smoke): update package-smoke.sh, remove update-packages-s…
Browse files Browse the repository at this point in the history
…moke-lock.sh, update package.json in package-smoke add description for local running
  • Loading branch information
denStrigo committed Nov 1, 2019
1 parent 5ed41c0 commit e7fd9e0
Show file tree
Hide file tree
Showing 7 changed files with 35 additions and 55 deletions.
4 changes: 0 additions & 4 deletions DEV_DOCS.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@
- add the package into packages-smoke application dependencies to verify it works properly in isolation.
- add the package into change-prefix.ts which builds our packages with custom prefix.

# New Package Dependency Checklist
- run `npm run update-packages-smoke-lock` to update packages-smoke/package-lock.json and commit updated package lock

# Objectives
The aim of the project is to create a set of useful Angular modules which help to bootstrap the development.

Expand Down Expand Up @@ -393,7 +390,6 @@ To start a new release (publish the framework packages on NPM) you need:
2. `npm run release:validate` - this will create ready for publishing packages in src/.lib then build prod & AOT builds of the playground app using prepared packages and then run e2e tests again it.
3. MANUALLY update a version in main ./package.json to a new one
4.
* `npm run update-packages-smoke-lock` to update `packages-smoke/package-lock.json`
* `npm run version:bump`
* update version in `package-lock.json` and `packages-smoke/package-lock.json`
* when releasing current version (PR to master) also update [docs/versions.json](#docs-deploy):
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
"release:dev": "npm-run-all release:prepare:dev publish",
"release": "npm-run-all release:validate publish",
"publish": "./scripts/publish.sh",
"update-packages-smoke-lock": "./scripts/update-packages-smoke-lock.sh",
"cli:firefox-fix": "rimraf node_modules/@angular-devkit/build-angular/node_modules/uglify-es && rimraf node_modules/@angular-devkit/build-angular/node_modules/uglifyjs-webpack-plugin",
"postinstall": "npm-run-all -p cli:firefox-fix build:dev-schematics",
"gen:playground": "ng g .:playground",
Expand Down
13 changes: 13 additions & 0 deletions packages-smoke/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,16 @@

This project is used to verify all nebular packages were built properly.
We just install newly build packages in this app and build it in production mode.

# For local running
1. Run `npm run release:prepare` - in root.
2. Copy folder .lib from `src/.lib` to `packages-smoke/.lib`
3. Go to folder packages-smoke run `npm install`
4. Verifying application build:
- `npm run build -- --prod`
- `npm run build -- --configuration=production-2015`
- `npm run e2e`
- `npm run e2e -- --configuration=production-2015`
5. Run with ssr:
- `npm run build:ssr`
- `npm run serve:ssr`
38 changes: 14 additions & 24 deletions packages-smoke/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions packages-smoke/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@
"@angular/platform-browser-dynamic": "8.0.0",
"@angular/platform-server": "8.0.0",
"@angular/router": "8.0.0",
"@nebular/auth": "4.1.3",
"@nebular/date-fns": "4.1.3",
"@nebular/eva-icons": "4.1.3",
"@nebular/moment": "4.1.3",
"@nebular/security": "4.1.3",
"@nebular/theme": "4.1.3",
"@nebular/auth": "file:.lib/auth",
"@nebular/date-fns": "file:.lib/date-fns",
"@nebular/eva-icons": "file:.lib/eva-icons",
"@nebular/moment": "file:.lib/moment",
"@nebular/security": "file:.lib/security",
"@nebular/theme": "file:.lib/theme",
"@nguniversal/express-engine": "^8.1.1",
"@nguniversal/module-map-ngfactory-loader": "8.1.1",
"core-js": "^2.5.7",
Expand Down
4 changes: 2 additions & 2 deletions scripts/ci/packages-smoke.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ packages_smoke() {

echo "Building packages"
npm run release:prepare
mkdir -p .lib && cp -r ../nebular/src/.lib/* .lib

echo "Setting up playground application for testing"
rm -rf ../${PROJECT}
cp -r ./${PROJECT} ../${PROJECT}
cd ../${PROJECT}
npm install

echo "Installing built packages"
cp -r ../nebular/src/.lib/* node_modules/@nebular
npm install

echo "Verifying application build"
npm run build -- --prod
Expand Down
18 changes: 0 additions & 18 deletions scripts/update-packages-smoke-lock.sh

This file was deleted.

0 comments on commit e7fd9e0

Please sign in to comment.