Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression introduced by PR #1007 ; can't select options in nb-select #1289

Closed
1 of 2 tasks
dragonbane0 opened this issue Mar 9, 2019 · 4 comments · Fixed by #1316
Closed
1 of 2 tasks

Regression introduced by PR #1007 ; can't select options in nb-select #1289

dragonbane0 opened this issue Mar 9, 2019 · 4 comments · Fixed by #1316
Assignees
Projects
Milestone

Comments

@dragonbane0
Copy link

dragonbane0 commented Mar 9, 2019

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description

Current behavior:
After updating @nebular/theme from 3.0.0 to 3.0.1 in my electron app I noticed that nb-select is now buggy and doesn't allow you to select any options (the list doesn't even come up) while it resides inside a nb-tabset (dynamically generated with a ngFor). The selects are also dynamically generated by a ng-template ngFor inside a nb-tab.

All the nb-selects that reside in the first tab that I click on do work. All the nb-selects in all the other tabs no longer show options when clicked. The nb-selects in the first tab that was clicked still work. This behaviour can be observed with any tab, as long as it is the first tab you click on after the app starts.

Expected behavior:
That you can always select your options in nb-select in any tab.

Steps to reproduce:
See current behaviour.

Related code:
As far as I can tell this bug was introduced by PR #1007. Reverting the associated commits while in version 3.0.1 fixes the issue again.

Other information:

npm, node, OS, Browser
node v10.15.1, Windows 7 x64, Electron running Chromium

Angular, Nebular
Angular 7+, Nebular 3.0.1 (still occurs in Nebular 3.4.0)

@nalinab
Copy link

nalinab commented Mar 11, 2019

Same Issue Noted above..I am using Nebular 3.4.0 and angular 7 from Nebular 2.0.1 and angular 6,After upgrading the both, I am getting the issues in nb-select template which is used inside nb-stepper in three forms, first form nb-select is working ,other form's nb-select are not working. Please tell me when this bug will be resolved and I am in mid way of completion of my project. Do I need to revert back the version?

@nnixaa
Copy link
Collaborator

nnixaa commented Mar 12, 2019

Most likely related #1292

@nnixaa nnixaa added this to the 3.5.0 milestone Mar 12, 2019
@nnixaa
Copy link
Collaborator

nnixaa commented Mar 12, 2019

Same goes for #1290

@nnixaa
Copy link
Collaborator

nnixaa commented Mar 12, 2019

#1292 and #1273 also might be related
#1230

@yggg yggg added this to Sprint in Nebular via automation Mar 21, 2019
@Tibing Tibing moved this from Sprint to In progress in Nebular Mar 26, 2019
@Tibing Tibing moved this from In progress to Needs review in Nebular Mar 26, 2019
@yggg yggg moved this from Needs review to Reviewer approved in Nebular Mar 28, 2019
@yggg yggg moved this from Reviewer approved to In progress in Nebular Mar 28, 2019
Nebular automation moved this from In progress to Done Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Nebular
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants