Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cdk): destroy overlay triggers manually #1316

Merged
merged 6 commits into from
Mar 29, 2019

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Mar 26, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1289, #1292, #1290, #1292, #1273
Rewrite overlay triggers to close them manually calling destroy() method.

@Tibing Tibing requested review from nnixaa and yggg March 26, 2019 12:30
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #1316 into master will increase coverage by <.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #1316      +/-   ##
==========================================
+ Coverage   80.65%   80.65%   +<.01%     
==========================================
  Files         232      232              
  Lines        7051     7036      -15     
  Branches      592      593       +1     
==========================================
- Hits         5687     5675      -12     
+ Misses       1190     1187       -3     
  Partials      174      174
Impacted Files Coverage Δ
...nts/cdk/overlay/dynamic/dynamic-overlay-handler.ts 100% <100%> (ø) ⬆️
...rk/theme/components/cdk/overlay/overlay-trigger.ts 96.59% <100%> (-0.35%) ⬇️
...heme/components/datepicker/datepicker.component.ts 89.88% <100%> (+0.05%) ⬆️
...mework/theme/components/select/select.component.ts 88.77% <50%> (+1.46%) ⬆️

@Tibing Tibing requested a review from yggg March 27, 2019 10:51
@Tibing Tibing requested a review from nnixaa March 28, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression introduced by PR #1007 ; can't select options in nb-select
4 participants