Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calendar): use last defined week day to determine week number #1969

Merged
merged 2 commits into from
Sep 20, 2019
Merged

fix(calendar): use last defined week day to determine week number #1969

merged 2 commits into from
Sep 20, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Sep 20, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #1969 into master will increase coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1969      +/-   ##
==========================================
+ Coverage   84.08%   84.11%   +0.02%     
==========================================
  Files         235      235              
  Lines        7793     7794       +1     
  Branches      681      681              
==========================================
+ Hits         6553     6556       +3     
+ Misses       1041     1039       -2     
  Partials      199      199
Impacted Files Coverage Δ
...lendar-day-picker/calendar-day-picker.component.ts 100% <ø> (ø) ⬆️
...r-week-number/nb-calendar-week-number.component.ts 64.7% <0%> (-4.05%) ⬇️
...rc/framework/theme/components/menu/menu.service.ts 88.02% <0%> (+0.7%) ⬆️
.../framework/theme/components/menu/menu.component.ts 78.04% <0%> (+1.62%) ⬆️

@yggg yggg merged commit ba78d94 into akveo:master Sep 20, 2019
@yggg yggg deleted the fix/calendar-find-last-defined-day-to-get-week branch September 20, 2019 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants