Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toastr): move toastr overlay in front of other overlays #2078

Merged
merged 4 commits into from
Nov 14, 2019

Conversation

FourthOf5
Copy link
Collaborator

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1986

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #2078 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2078      +/-   ##
==========================================
+ Coverage   84.58%   84.58%   +<.01%     
==========================================
  Files         235      235              
  Lines        8037     8040       +3     
  Branches      707      707              
==========================================
+ Hits         6798     6801       +3     
  Misses       1020     1020              
  Partials      219      219
Impacted Files Coverage Δ
...ramework/theme/components/toastr/toastr.service.ts 97.56% <100%> (+0.06%) ⬆️

@yggg yggg merged commit 906d3c0 into akveo:master Nov 14, 2019
@FourthOf5 FourthOf5 deleted the fix/toastr-covered-by-dialog branch November 14, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbToastr show under nbDialog
2 participants