Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nb-icon): return null if icon wasn't found #2466

Merged
merged 6 commits into from
Jul 31, 2020

Conversation

mmfKupl
Copy link
Member

@mmfKupl mmfKupl commented Jul 29, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

remove icon not found error thrown so that you can dynamically change the icon, and so that after the first installation of the wrong icon, you can change it

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #2466 into master will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2466      +/-   ##
==========================================
- Coverage   80.46%   80.41%   -0.05%     
==========================================
  Files         244      244              
  Lines        7172     7180       +8     
  Branches      785      787       +2     
==========================================
+ Hits         5771     5774       +3     
- Misses       1168     1171       +3     
- Partials      233      235       +2     
Impacted Files Coverage Δ
.../framework/theme/components/icon/icon.component.ts 87.93% <33.33%> (-8.15%) ⬇️
.../framework/theme/components/icon/icon-libraries.ts 87.27% <100.00%> (+0.23%) ⬆️

@yggg yggg changed the title fix(icon-component): remove icon not found error and allow empty icon refactor(nb-icon): return null if icon wasn't found Jul 31, 2020
@yggg yggg merged commit 4af8924 into akveo:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants