Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Documentation for auth-install.md #273

Closed
1 of 2 tasks
nabgilby opened this issue Feb 25, 2018 · 0 comments
Closed
1 of 2 tasks

Incorrect Documentation for auth-install.md #273

nabgilby opened this issue Feb 25, 2018 · 0 comments

Comments

@nabgilby
Copy link

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request

Issue description

Current behavior:

including the @import and @include statements in themes.scss causes compile errors:
Media query expression must begin with '('
in /src/app/@theme/styles/themes.scss (line 10, column 1)

Expected behavior:

No build errors, documentation is corrected with the more details link fixed.

------------- Details -----------------------------------
auth-install.md
5. Last but not least - install the component styles into your themes.scss (more details):
@import '@nebular/auth/styles/all'; // or @import '@nebular/auth/styles/{theme-name}';

// ...

@include nb-install() {
@include nb-theme-global();
@include nb-auth-global(); // append the install mixin inside of the nb-install
};


  • more details link is broken
  • in the ngx-admin example, the @import and @include statements are included in styles.css not themes.scss, including them in themes.scss as well causes multiple errors.

Angular, Nebular

<!--
Check your `package-lock.json` or locate a `package.json` in the `node_modules` folder.
-->

@angular/cli":
"version": "1.7.1",
"@nebular/auth": {
"version": "2.0.0-rc.6",

@nnixaa nnixaa added this to the rc.8 milestone Apr 10, 2018
@nnixaa nnixaa modified the milestones: rc.8, rc.9 Apr 21, 2018
nnixaa added a commit that referenced this issue Jun 15, 2018
@nnixaa nnixaa closed this as completed in 180d8f1 Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants