Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor overlays after @angular/cdk@7.0.0 relase #848

Closed
Tibing opened this issue Oct 2, 2018 · 1 comment
Closed

Refactor overlays after @angular/cdk@7.0.0 relase #848

Tibing opened this issue Oct 2, 2018 · 1 comment
Labels
module:theme P2: important
Milestone
3.2.0

Comments

@Tibing
Copy link
Member

Tibing commented Oct 2, 2018

We've added some workarounds in current overlays implementation because of incorrect implementation of cdk overlays. They don't provide the capability to provide component factory resolver into the portal, so we don't have the capability to render components in lazily loaded modules through services provided in the application root.
@Tibing Tibing added the Backlog label Oct 2, 2018
@fahimalizain
Copy link

Linked #943 ?

@nnixaa nnixaa mentioned this issue Jan 15, 2019
Merged
@issue-sh issue-sh bot removed the Backlog label Jan 15, 2019
nnixaa added a commit that referenced this issue Jan 15, 2019
@nnixaa
fix(popover): fix template context not being passed, update cdk to 7.…
c83188c 
…2.1 (#1153)

Closes #1084 
Closes #848
@nnixaa nnixaa added this to the 3.2.0 milestone Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module:theme P2: important
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
3 participants
@nnixaa @fahimalizain @Tibing