Feat/tooltip trigger #1138
Merged
Feat/tooltip trigger #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(overlay): trigger strategy builder is a service now * refactor(overlay): remove document setter * refactor(popover): rename mode to trigger, deprecate mode * feat(overlay): noop trigger * docs(popover): add noop example
nnixaa
commented
Jan 8, 2019
nnixaa
force-pushed
the
feat/tooltip-trigger
branch
from
e13c727
to
c823cc2
Compare
nnixaa
force-pushed
the
feat/tooltip-trigger
branch
from
2a1578b
to
e4f45ca
Compare
Tibing
requested changes
Jan 9, 2019
| * | ||
| * - Click mode shows the component when a user clicks on the host element and hides when the user clicks | ||
| * somewhere on the document outside the component. | ||
| * - Hint provides capability show$ the component when the user hovers over the host element |
There was a problem hiding this comment.
Suggested change
| * - Hint provides capability show$ the component when the user hovers over the host element | |
| * - Hint provides capability show the component when the user hovers over the host element |
| * - Click mode shows the component when a user clicks on the host element and hides when the user clicks | ||
| * somewhere on the document outside the component. | ||
| * - Hint provides capability show$ the component when the user hovers over the host element | ||
| * and hide$ when user hovers out of the host. |
There was a problem hiding this comment.
Suggested change
| * and hide$ when user hovers out of the host. | |
| * and hide when the user hovers out of the host. |
| */ | ||
| @Directive({ selector: '[nbTooltip]' }) | ||
| export class NbTooltipDirective implements AfterViewInit, OnDestroy { | ||
|
|
||
| context: Object = {}; | ||
|
|
||
| /** | ||
| * Popover content which will be rendered in NbTooltipComponent. | ||
| * Tooltip content which will be rendered in NbTooltipComponent. | ||
| * Available content: template ref, component and any primitive. |
There was a problem hiding this comment.
I don't think it is a correct statement. NbTooltipDirective may accept only string content: https://github.com/akveo/nebular/pull/1138/files#diff-d0e689a1ded55212ebd0a0202c9dc95bR86
Tibing
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves: