Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tooltip trigger #1138

Merged
merged 5 commits into from
Jan 9, 2019
Merged

Feat/tooltip trigger #1138

merged 5 commits into from
Jan 9, 2019

Conversation

nnixaa
Copy link
Collaborator

@nnixaa nnixaa commented Jan 8, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

* refactor(overlay): trigger strategy builder is a service now

* refactor(overlay): remove document setter

* refactor(popover): rename mode to trigger, deprecate mode

* feat(overlay): noop trigger

* docs(popover): add noop example
@nnixaa nnixaa added the WIP label Jan 8, 2019
*
* - Click mode shows the component when a user clicks on the host element and hides when the user clicks
* somewhere on the document outside the component.
* - Hint provides capability show$ the component when the user hovers over the host element
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* - Hint provides capability show$ the component when the user hovers over the host element
* - Hint provides capability show the component when the user hovers over the host element

* - Click mode shows the component when a user clicks on the host element and hides when the user clicks
* somewhere on the document outside the component.
* - Hint provides capability show$ the component when the user hovers over the host element
* and hide$ when user hovers out of the host.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* and hide$ when user hovers out of the host.
* and hide when the user hovers out of the host.

*/
@Directive({ selector: '[nbTooltip]' })
export class NbTooltipDirective implements AfterViewInit, OnDestroy {

context: Object = {};

/**
* Popover content which will be rendered in NbTooltipComponent.
* Tooltip content which will be rendered in NbTooltipComponent.
* Available content: template ref, component and any primitive.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is a correct statement. NbTooltipDirective may accept only string content: https://github.com/akveo/nebular/pull/1138/files#diff-d0e689a1ded55212ebd0a0202c9dc95bR86

@nnixaa nnixaa merged commit 113d3b0 into master Jan 9, 2019
@nnixaa nnixaa deleted the feat/tooltip-trigger branch January 9, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants