feat(theme): css variables support #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: - calendar - use primary button in cosmic theme - checkbox - `opacity` instead of `lightning` - context-menu, popover, datepicker - `calc` instead of `round` and scss calculations - input - `opacity` for placeholder instead of `lightning` - tabs - remove gradient for tab bottom separator in cosmic theme - toastr - use `background-color` instead of gradient in cosmic theme - text colors are now used from success/primary/warning/etc colors - add color palett instead of generating colors using scss-functions, example for `primary` `color-primary-200` `color-primary-300` `color-primary-400` `color-primary-600` `color-primary-700` and create-colors-palette() scss function that can be used during theme installation process to generate palette automatically
nnixaa
force-pushed
the
feat/theme-css-system-new
branch
from
5fdb17c
to
15d3929
Compare
yggg
reviewed
Mar 14, 2019
| } | ||
| } | ||
| } | ||
|
|
||
| // TODO: we hide :host inside of it which is not obvious | ||
| @mixin nb-install-component() { | ||
| @mixin nb-install-component-new() { |
There was a problem hiding this comment.
Maybe it's better to change new to with-css-props-support? Same for old and following nb-install-global-new and nb-install-global-old mixins.
yggg
reviewed
Mar 14, 2019
nnixaa
force-pushed
the
feat/theme-css-system-new
branch
from
7e2fed2
to
7bcd5c7
Compare
# Conflicts: # src/app/playground-components.ts # src/framework/theme/components/button/_button-heroes.scss # src/playground/with-layout/typography/typography-showcase.component.html # src/playground/with-layout/with-layout-routing.module.ts
yggg
approved these changes
Mar 21, 2019
yggg
pushed a commit
that referenced
this pull request
Mar 28, 2019
nnixaa
added a commit
that referenced
this pull request
Apr 1, 2019
brannon-darby
pushed a commit
to brannon-darby/nebular
that referenced
this pull request
Apr 5, 2019
brannon-darby
pushed a commit
to brannon-darby/nebular
that referenced
this pull request
Apr 5, 2019
brannon-darby
pushed a commit
to brannon-darby/nebular
that referenced
this pull request
Apr 5, 2019
yggg
pushed a commit
that referenced
this pull request
Apr 17, 2019
yggg
pushed a commit
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46