feat(tooltip): Eva style #1345
Merged
feat(tooltip): Eva style #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: Following tooltip theme properties were renamed: tooltip-bg -> tooltip-background-color tooltip-fg -> tooltip-text-color tooltip-font-size -> tooltip-text-font-size tooltip-status-fg -> tooltip-background-color, tooltip-text-color, tooltip-[status]-background-color, tooltip-[status]-text-color
BREAKING CHANGES: Tooltip status class renamed from [status-name]-tooltip to status-[status-name].
nnixaa
approved these changes
Apr 3, 2019
| @include nb-tooltip-status('warning'); | ||
| @include nb-tooltip-status('info'); | ||
| @each $status in nb-get-statuses() { | ||
| @include nb-tooltip-status($status); |
There was a problem hiding this comment.
same question regarding empty status
nnixaa
previously approved these changes
Apr 4, 2019
nnixaa
approved these changes
Apr 5, 2019
Codecov Report
@@ Coverage Diff @@
## next #1345 +/- ##
=======================================
Coverage 81.63% 81.63%
=======================================
Files 237 237
Lines 7275 7275
Branches 626 626
=======================================
Hits 5939 5939
Misses 1150 1150
Partials 186 186
|
yggg
added a commit
that referenced
this pull request
Apr 17, 2019
BREAKING CHANGE: Following tooltip theme properties were renamed: tooltip-bg -> tooltip-background-color tooltip-fg -> tooltip-text-color tooltip-font-size -> tooltip-text-font-size tooltip-status-fg -> tooltip-[status]-text-color tooltip-primary-bg -> tooltip-primary-background-color tooltip-info-bg -> tooltip-info-background-color tooltip-success-bg -> tooltip-success-background-color tooltip-warning-bg -> tooltip-warning-background-color tooltip-danger-bg -> tooltip-danger-background-color Tooltip status class renamed from [status-name]-tooltip to status-[status-name].
yggg
added a commit
that referenced
this pull request
May 27, 2019
BREAKING CHANGE: Following tooltip theme properties were renamed: tooltip-bg -> tooltip-background-color tooltip-fg -> tooltip-text-color tooltip-font-size -> tooltip-text-font-size tooltip-status-fg -> tooltip-[status]-text-color tooltip-primary-bg -> tooltip-primary-background-color tooltip-info-bg -> tooltip-info-background-color tooltip-success-bg -> tooltip-success-background-color tooltip-warning-bg -> tooltip-warning-background-color tooltip-danger-bg -> tooltip-danger-background-color Tooltip status class renamed from [status-name]-tooltip to status-[status-name].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
BREAKING CHANGES:
Following tooltip theme properties were renamed:
tooltip-bg -> tooltip-background-color
tooltip-fg -> tooltip-text-color
tooltip-font-size -> tooltip-text-font-size
tooltip-status-fg -> tooltip-[status]-text-color
tooltip-primary-bg -> tooltip-primary-background-color
tooltip-info-bg -> tooltip-info-background-color
tooltip-success-bg -> tooltip-success-background-color
tooltip-warning-bg -> tooltip-warning-background-color
tooltip-danger-bg -> tooltip-danger-background-color
Tooltip status class renamed from [status-name]-tooltip to
status-[status-name].