fix(option group): propagate disabled state to child options #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnixaa
previously approved these changes
Apr 24, 2019
Tibing
requested changes
Apr 24, 2019
src/framework/theme/components/select/option-group.component.spec.ts
Outdated
Show resolved
Hide resolved
| expect(setDisabledSpy).toHaveBeenCalledWith(true); | ||
| }); | ||
|
|
||
| it('should enable options if set enabled', () => { |
There was a problem hiding this comment.
I think that way test name will be more readable 😄
Suggested change
| it('should enable options if set enabled', () => { | |
| it('should enable group options if group enabled', () => { |
| @@ -119,6 +122,17 @@ export class NbOptionComponent<T> implements OnDestroy { | |||
| this.setSelection(false); | |||
| } | |||
|
|
|||
| /** | |||
| * Sets disabled by group state and marks component for check. | |||
| * @param disabled group disabled state | |||
There was a problem hiding this comment.
Do we really need to specify that @param?
| `, | ||
| }) | ||
| export class NbOptionGroupTestComponent { | ||
| selectDisabled: boolean = false; |
There was a problem hiding this comment.
Let's not specify the property type when we assign value during the declaration. I've described that slightly deeper in some comment below.
| `, | ||
| }) | ||
| export class NbOptionDisabledTestComponent { | ||
| optionGroupDisabled: boolean = false; |
There was a problem hiding this comment.
Let's not specify the property type when we assign value during the declaration. I've described that slightly deeper in some comment above.
Codecov Report
@@ Coverage Diff @@
## next #1416 +/- ##
=========================================
+ Coverage 82.5% 82.61% +0.11%
=========================================
Files 238 238
Lines 7270 7294 +24
Branches 647 651 +4
=========================================
+ Hits 5998 6026 +28
+ Misses 1083 1080 -3
+ Partials 189 188 -1
|
Tibing
previously approved these changes
Apr 24, 2019
Tibing
approved these changes
Apr 24, 2019
yggg
added a commit
that referenced
this pull request
May 27, 2019
yggg
added a commit
that referenced
this pull request
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Disable options if group disabled