Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(window): create new window container when overlay container change #1867

Merged
merged 4 commits into from
Aug 26, 2019
Merged

fix(window): create new window container when overlay container change #1867

merged 4 commits into from
Aug 26, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jul 29, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1238

@yggg yggg requested a review from nnixaa July 29, 2019 16:07
@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #1867 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1867      +/-   ##
==========================================
+ Coverage      84%   84.02%   +0.01%     
==========================================
  Files         234      234              
  Lines        7686     7695       +9     
  Branches      673      675       +2     
==========================================
+ Hits         6457     6466       +9     
  Misses       1031     1031              
  Partials      198      198
Impacted Files Coverage Δ
...ramework/theme/components/window/window.service.ts 98.63% <100%> (+0.19%) ⬆️

@yggg yggg merged commit edb6b16 into akveo:master Aug 26, 2019
@yggg yggg deleted the fix/window-create-new-container-when-old-removed branch August 26, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NbWindowService Error 'Element matching '[cdkFocusInitial]' is not focusable'
2 participants