feat(theme): form field component #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2238 +/- ##
=========================================
- Coverage 84.71% 84.41% -0.3%
=========================================
Files 243 248 +5
Lines 8478 8605 +127
Branches 759 772 +13
=========================================
+ Hits 7182 7264 +82
- Misses 1073 1114 +41
- Partials 223 227 +4
|
Tibing
requested changes
Feb 26, 2020
Comment on lines
115
to
117
| @ContentChild(NbInputDirective, { static: false }) formControl: NbInputDirective; | ||
| @ContentChild(NbInputDirective, { static: false, read: ElementRef }) formControlElement: ElementRef<HTMLInputElement>; | ||
|
|
There was a problem hiding this comment.
I would personally prefer to name it input instead of formControl since we're querying input
src/framework/theme/components/form-field/form-field.component.ts
Outdated
Show resolved
Hide resolved
There is a cases when padding should be added to the element other than host, e.g. select as it has padding set on button inside host element.
Select doesn't support suffix.
Tibing
previously approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Closes #1999