Created conditional show minimize/maximize action buttons on window component

[cesarochoa2006]

Please read and mark the following check list before creating a pull request:

• I read and followed the CONTRIBUTING.md guide.
• I read and followed the New Feature Checklist guide.

Short description of what this resolves:

Adds a new feature that show/hide action buttons (minimize/maximize) with the config option "showActions" of window component that can be configured when the component is used. By default, it works like before, and the added option is by default true, so can be changed to false whenever it is desired to work. Also, added the css class no actions, to correctly display the close button when the actions buttons are not shown.
This feature is added because i had the need of hide minimize/maximize buttons of a window component.

[codecov]

Codecov Report

Merging #2286 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2286   +/-   ##
=======================================
  Coverage   81.53%   81.53%           
=======================================
  Files         244      244           
  Lines        7377     7378    +1     
  Branches      773      773           
=======================================
+ Hits         6015     6016    +1     
  Misses       1135     1135           
  Partials      227      227           

Impacted Files	Coverage Δ
...mework/theme/components/window/window.component.ts	83.01% <ø> (ø)
...ramework/theme/components/window/window.options.ts	100.00% <100.00%> (ø)

[naingaungphyo]

Any update about when will this feature be merged and released?

[naingaungphyo]

@cesarochoa2006
Thanks for the great work! It will be great if there is an option to disable each button that we don't want.
For me, I think "maximize" button is not really useful. So I want to have only "minimize" button and "close" button.

[cesarochoa2006]

Thanks. In fact, i have no idea of when it will be merged :(. Hopefully soon. I have no control over it. El jue., 26 mar. 2020 a las 21:19, Naing Aung Phyo (< notifications@github.com>) escribió:

…

Any update about when will this feature be merged and available in master? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2286 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFKKWRHQIGGPAJXLGBCHYFDRJQELRANCNFSM4LQ6TPAQ> .

[naingaungphyo]

fyi,
current workaround for me to hide them manually is hiding them with overwriting css.

[cesarochoa2006]

fyi,
current workaround for me to hide them manually is hiding them with overwriting css.

¿ But with css you hide all buttons ? I need the close button displayed

[naingaungphyo]

nope, I can hide specific button with css coz they have different class to be overwritten.

[cesarochoa2006]

Can hoy share with me the css that have you applied? I see no css classes applied here El jue., 7 de mayo de 2020 9:40 p. m., Naing Aung Phyo < notifications@github.com> escribió:

…

nope, I can hide specific button with css coz they have different class to be overwritten. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2286 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFKKWRADPBB6CEE753VK26LRQNWJ5ANCNFSM4LQ6TPAQ> .

[naingaungphyo]

sorry, I said wrong information. I hide with nth-child selectors like this.

// hide maximize
nb-windows-container> nb-window > nb-card > nb-card-header> div:nth-child(2)> button:nth-child(2)
{
  display: none;
}
nb-windows-container>nb-window>nb-card>nb-card-header>.buttons
{
  justify-content: flex-end !important;
}
// hide minimize
.no-minimize-window > nb-card > nb-card-header> div:nth-child(2)> button:first-child
{
  visibility: hidden;
}

[cesarochoa2006]

Well, is a good alternative. Thanks for sharing it, i didn't know those css. El jue., 7 de mayo de 2020 10:34 p. m., Naing Aung Phyo < notifications@github.com> escribió:

…

sorry, I said wrong information. I hide with nth-child selectors like this. // hide maximum nb-windows-container> nb-window > nb-card > nb-card-header> div:nth-child(2)> button:nth-child(2) { display: none; } nb-windows-container>nb-window>nb-card>nb-card-header>.buttons { justify-content: flex-end !important; } // hide minimize .no-minimize-window > nb-card > nb-card-header> div:nth-child(2)> button:first-child { visibility: hidden; } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2286 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFKKWRAXP4J2TYL3PJHWLH3RQN4UFANCNFSM4LQ6TPAQ> .

[JamesKnippel]

Would be great to be able to add a confirmation dialog on the close button as well. Shame this hasn't been pushed yet.

[naingaungphyo]

@JamesKnippel Yeah.
Also I want to hold the state of the dialog input value before the dialog being minimized. onDestroy is called when we minimize the dialog and BOOM! all the value of inputs are gone. So even I call the dialog again from minimize state, I can't get the old form state back.

[JamesKnippel]

@naingaungphyo That's my biggest problem too - I'm looking into some sort of solution with maybe storing template data on a backend with post requests and repopulating from a temporary form-data table.

I want to be able to walk away and open up the same minimized windows on another computer with the same state from old forms. I'll let you know if I come up with any workarounds.
I really wish Nebular was more open with communications! I really love the framework and this Window is probably their most standout component with so much potential

[yggg]

Closed by #2762