Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autocomplete): input for focus on value change #2356

Merged
merged 1 commit into from
Jun 3, 2020
Merged

feat(autocomplete): input for focus on value change #2356

merged 1 commit into from
Jun 3, 2020

Conversation

jornetsimon
Copy link
Contributor

An input to control the focus behaviour when the control value changes

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Ref #2355
Introduces an Input to NbAutocompleteDirective to control the focus behaviour when the control value is set (-> writeValue).

An input to control the focus behaviour when the control value changes
@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #2356 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2356      +/-   ##
==========================================
+ Coverage   81.53%   81.54%   +0.01%     
==========================================
  Files         244      244              
  Lines        7377     7382       +5     
  Branches      773      774       +1     
==========================================
+ Hits         6015     6020       +5     
+ Misses       1135     1132       -3     
- Partials      227      230       +3     
Impacted Files Coverage Δ
.../components/autocomplete/autocomplete.directive.ts 81.29% <66.66%> (-0.71%) ⬇️
...endar-kit/services/calendar-month-model.service.ts 96.07% <0.00%> (-1.97%) ⬇️
...ramework/theme/components/toastr/toastr.service.ts 97.39% <0.00%> (+2.60%) ⬆️

@yggg yggg merged commit ab15806 into akveo:master Jun 3, 2020
@yggg
Copy link
Contributor

yggg commented Jun 3, 2020

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants