Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/detach bootstrap #707

Merged
merged 13 commits into from
Sep 12, 2018
Merged

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Sep 11, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

BREAKING CHANGE:

  • All bootstrap overrides were moved from the @nebular/theme package to the new @nebular/bootstrap package.

  • @nebular/theme package introduced dependency of normalize.css.

  • @nebular/auth package now depends on @nebular/bootstrap.

@Tibing Tibing requested a review from nnixaa September 11, 2018 13:25
Copy link
Collaborator

@nnixaa nnixaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to state the BREAKING CHANGE comment carefully describing how to update

angular.json Show resolved Hide resolved
docs/app/@theme/styles/styles.scss Show resolved Hide resolved
docs/articles/bootstrap-integration.md Outdated Show resolved Hide resolved
docs/articles/bootstrap-integration.md Outdated Show resolved Hide resolved
docs/articles/bootstrap-integration.md Outdated Show resolved Hide resolved
docs/articles/bootstrap-integration.md Outdated Show resolved Hide resolved
docs/structure.ts Outdated Show resolved Hide resolved
src/framework/bootstrap/package.json Show resolved Hide resolved
@nnixaa nnixaa merged commit a25f615 into akveo:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants