Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form controls): mark as touched #864

Merged
merged 9 commits into from
Oct 11, 2018
Merged

fix(form controls): mark as touched #864

merged 9 commits into from
Oct 11, 2018

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Oct 5, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fix ControlValueAccessor implementation in nebular form controls.
Closes #367.

@yggg yggg added the WIP label Oct 5, 2018
@yggg yggg requested review from nnixaa and Tibing October 5, 2018 12:28
takeWhile(() => this.alive),
// wait for focus to be applied to another radio in case it moved within radio group.
delay(100),
filter(() => !this.radios.some(radio => radio.hasFocus)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delay(100) in this case may lead to unexpected behavior. So, maybe, we may remove it?

@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #864 into master will decrease coverage by 0.2%.
The diff coverage is 60.31%.

@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
- Coverage   76.96%   76.75%   -0.21%     
==========================================
  Files         201      201              
  Lines        5913     5963      +50     
  Branches      449      454       +5     
==========================================
+ Hits         4551     4577      +26     
- Misses       1258     1281      +23     
- Partials      104      105       +1
Impacted Files Coverage Δ
...ramework/theme/components/radio/radio.component.ts 100% <100%> (ø) ⬆️
...mework/theme/components/select/select.component.ts 84.65% <47.05%> (-3.54%) ⬇️
...heme/components/datepicker/datepicker.directive.ts 63.2% <50%> (-2.45%) ⬇️
...heme/components/datepicker/datepicker.component.ts 82.85% <62.5%> (-1.36%) ⬇️
...rk/theme/components/radio/radio-group.component.ts 77.63% <66.66%> (-5.42%) ⬇️
...rk/theme/components/checkbox/checkbox.component.ts 91.66% <83.33%> (-2.28%) ⬇️

@yggg yggg removed the WIP label Oct 8, 2018
@nnixaa nnixaa merged commit e06d3a7 into akveo:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nb-checkbox always dirty
3 participants