Update to allow for edit not to be performed on the data source #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New setting 'confirm.resolve.skipAdd'=true will skip adding the new entry to the data source. Added to allow for better integration with rxjs and ngrx.
…updated by an Observable New settings 'confirm.resolve.skipEdit'=true will not perform any change to the data source after an edit has been performed. This change was done to resolve an issue when the data source is being updated by an Observable. This will allow for a better integration of the smart table to rxjs and ngrx.
Added missing bracket
|
@Ezeon thanks for PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
New setting 'confirm.resolve.skipEdit'=true will not perform the edit on the data source. This issue is similar to PR #274. This two changes will allow a better integration with rxjs and ngrx.
Short summary of issue:
The function event.confirm.resolve() does two separate things at the moment:
This pull request allows the event.confirm.resolve() to only (1) modify the UI controls, and not (2) perform the edit on the data source by setting the new parameter 'skipEdit' to true.
Currently an error condition might happen when the smart table is used together with Observables. The issue is further described in Issue #279