-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for custom filter components #825
Conversation
…using a number input
…hanges to input-filter to properly updated on setFilters.
…ngOnChanges in custom-table-filter.
@nnixaa Could you review this PR please? |
I'm needing this PR to be merged so badly 😂 |
I have a task stucked because of this for almost one month…. |
I'm still hoping the maintainers of this repo show up at some point, but until then feel free to use my fork: https://www.npmjs.com/package/ee-ng-smart-table |
@Ivan0xFF thanks, I'll probably do that when I'm back to work 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Ivan0xFF, so far so good! A couple of formatting issues and let's merge it.
src/app/pages/examples/custom-edit-view/custom-filter.component.ts
Outdated
Show resolved
Hide resolved
src/app/pages/examples/custom-edit-view/custom-filter.component.ts
Outdated
Show resolved
Hide resolved
src/ng2-smart-table/components/filter/custom-filter.component.ts
Outdated
Show resolved
Hide resolved
src/ng2-smart-table/components/filter/filter-types/input-filter.component.ts
Outdated
Show resolved
Hide resolved
Hey guys, Any news about this merge? |
ping @Ivan0xFF |
Sorry about the delay, work has been crazy. Hopefully this is good for merging now! |
Thank guys. Amazing work!!! @Ivan0xFF @nnixaa |
i've been trying to pass query to my custom filter but i didn't know how to do this |
Fixes #632 , #569, #447, possibly others.