Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for custom filter components #825

Merged
merged 5 commits into from
Feb 19, 2019
Merged

Support for custom filter components #825

merged 5 commits into from
Feb 19, 2019

Conversation

craftycorvid
Copy link
Contributor

  • Added support for custom filter components.
  • Created a quick examples using a number input

Fixes #632 , #569, #447, possibly others.

@craftycorvid craftycorvid changed the title Added support for custom filter components. Created a quick examples … Support for custom filter components Jun 29, 2018
@ksavidetove
Copy link

@nnixaa Could you review this PR please?

@I-NOZex
Copy link

I-NOZex commented Nov 23, 2018 •
edited
Loading

I'm needing this PR to be merged so badly 😂
Notify me when that happen, thank you!

@I-NOZex
Copy link

I-NOZex commented Dec 20, 2018

I have a task stucked because of this for almost one month….
@nnixaa @damnko @Tibing @lexzhukov @Deilan @ahmad-magdy can anyone of you guys pleaseee merge this? 😓

@craftycorvid
Copy link
Contributor Author

I'm still hoping the maintainers of this repo show up at some point, but until then feel free to use my fork: https://www.npmjs.com/package/ee-ng-smart-table

@I-NOZex
Copy link

I-NOZex commented Dec 20, 2018

@Ivan0xFF thanks, I'll probably do that when I'm back to work 👍

nnixaa
nnixaa requested changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@nnixaa nnixaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Ivan0xFF, so far so good! A couple of formatting issues and let's merge it.

src/app/pages/examples/custom-edit-view/custom-filter.component.ts Outdated Show resolved Hide resolved
src/app/pages/examples/custom-edit-view/custom-filter.component.ts Outdated Show resolved Hide resolved
src/ng2-smart-table/components/filter/custom-filter.component.ts Outdated Show resolved Hide resolved
src/ng2-smart-table/components/filter/filter-default.ts Outdated Show resolved Hide resolved
src/ng2-smart-table/components/filter/filter-types/input-filter.component.ts Outdated Show resolved Hide resolved
src/ng2-smart-table/components/filter/filter.component.ts Outdated Show resolved Hide resolved
@lfmmachado
Copy link

Hey guys,

Any news about this merge?

@nnixaa
Copy link
Contributor

nnixaa commented Feb 13, 2019

ping @Ivan0xFF

@craftycorvid
Copy link
Contributor Author

Sorry about the delay, work has been crazy. Hopefully this is good for merging now!

@lfmmachado
Copy link

@nnixaa

@nnixaa nnixaa merged commit b4713d9 into akveo:master Feb 19, 2019
@lfmmachado
Copy link

Thank guys. Amazing work!!! @Ivan0xFF @nnixaa

@ahmadnouh97
Copy link

i've been trying to pass query to my custom filter but i didn't know how to do this
the custom filter appears but the filter doesn't work :(
i'm using this fork
https://www.npmjs.com/package/ee-ng-smart-table
could you please provide link for an example about using custom filter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnixaa nnixaa nnixaa approved these changes

@I-NOZex I-NOZex I-NOZex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Filtering
6 participants
@craftycorvid @ksavidetove @I-NOZex @lfmmachado @nnixaa @ahmadnouh97